Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ray.tune usage example. #209

Merged
merged 14 commits into from
Feb 4, 2022
Merged

Improve ray.tune usage example. #209

merged 14 commits into from
Feb 4, 2022

Conversation

bwohlberg
Copy link
Collaborator

Improve ray.tune usage example. Also:

  • Some minor improvements to scico.ray.tune wrapper.
  • Extend tests for scico.ray.tune.
  • Add ray.tune usage example to examples index.

@bwohlberg bwohlberg added documentation Improvements or additions to documentation improvement Improvement of existing code, including addressing of omissions or inconsistencies labels Feb 3, 2022
@bwohlberg bwohlberg requested a review from smajee February 3, 2022 15:25
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #209 (32dd02b) into main (88b9cb4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   92.22%   92.24%   +0.01%     
==========================================
  Files          48       48              
  Lines        3345     3351       +6     
==========================================
+ Hits         3085     3091       +6     
  Misses        260      260              
Flag Coverage Δ
unittests 92.24% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/ray/tune.py 95.74% <100.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b9cb4...32dd02b. Read the comment docs.

Copy link
Contributor

@smajee smajee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the concern about removal of example dependencies.

pip install -r examples/examples_requirements.txt # Installs other example requirements

The dependencies can also be installed individually as required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you remove the example related dependencies? I don't think these are there anywhere else.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a continual pain until #195 is addressed. I'll fix manually for now.

@@ -1,5 +1,5 @@
# -*- coding: utf-8 -*-
# Copyright (C) 2021 by SCICO Developers
# Copyright (C) 2021-2022 by SCICO Developers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other files, should the end year be the current year or the year the file was last edited on?
In the long-term, should we manually update these or should we make a script (say in scico/misc) that updates these automatically.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the end year should correspond to the year of most recent edit. I think we can live with manual updates for now.

@bwohlberg bwohlberg linked an issue Feb 4, 2022 that may be closed by this pull request
@bwohlberg bwohlberg merged commit 3ff6945 into main Feb 4, 2022
@bwohlberg bwohlberg deleted the brendt/tune-example branch February 4, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies for examples
2 participants