Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tabs with spaces #201

Merged
merged 6 commits into from
Feb 1, 2022
Merged

Replace tabs with spaces #201

merged 6 commits into from
Feb 1, 2022

Conversation

bwohlberg
Copy link
Collaborator

Replace tabs with spaces. Resolves #199.

@bwohlberg bwohlberg added the documentation Improvements or additions to documentation label Jan 31, 2022
@bwohlberg bwohlberg requested a review from tbalke January 31, 2022 22:39
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #201 (b024c67) into main (45cfb92) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files          48       48           
  Lines        3351     3351           
=======================================
  Hits         3091     3091           
  Misses        260      260           
Flag Coverage Δ
unittests 92.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45cfb92...b024c67. Read the comment docs.

@tbalke
Copy link
Contributor

tbalke commented Jan 31, 2022

Only these? I am getting:

docs/Makefile
docs/source/notes.rst
docs/source/optimizer.rst
docs/source/references.bib
docs/source/style.rst
examples/scriptcheck.sh
misc/conda/install_conda.sh
misc/conda/make_conda_env.sh

@bwohlberg
Copy link
Collaborator Author

I don't think that really matters, but I've replaced the tabs in all but docs/source/references.bib, which will have to remain as it is since the emacs bibtex mode uses tabs for formatting.

@tbalke
Copy link
Contributor

tbalke commented Feb 1, 2022

I don't think that really matters, but I've replaced the tabs in all but docs/source/references.bib, which will have to remain as it is since the emacs bibtex mode uses tabs for formatting.

Odd, I am still getting 42 hits in:

examples/scriptcheck.sh
misc/conda/install_conda.sh
misc/conda/make_conda_env.sh

@bwohlberg
Copy link
Collaborator Author

I removed the tabs used sed, but they must have been re-introduced by emacs when I fixed the indentation. Consider shell scripts as added to the "won't fix" list for this.

@bwohlberg bwohlberg merged commit 982e86e into main Feb 1, 2022
@bwohlberg bwohlberg deleted the brendt/tabs branch February 1, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab vs. Space Policy
2 participants