Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda install scripts #178

Merged
merged 11 commits into from
Jan 26, 2022
Merged

Update conda install scripts #178

merged 11 commits into from
Jan 26, 2022

Conversation

bwohlberg
Copy link
Collaborator

Update conda install scripts:

  • Update jaxlib version
  • Update astra-toolbox install method
  • Default Python version now 3.9
  • Handle additional dependencies for svmbir and bm3d

@bwohlberg bwohlberg added the packaging Issues related to packaging, dependencies, etc. label Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #178 (0ab6c9c) into main (06e4bbf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files          48       48           
  Lines        3353     3353           
=======================================
  Hits         3093     3093           
  Misses        260      260           
Flag Coverage Δ
unittests 92.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e4bbf...0ab6c9c. Read the comment docs.

@bwohlberg bwohlberg marked this pull request as ready for review January 24, 2022 19:05
Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my shell (zsh on mac), ./make_conda_env.sh gives the error

./make_conda_env.sh: line 63: syntax error near unexpected token `&'

@bwohlberg
Copy link
Collaborator Author

Almost certainly due to incompatibilities between zsh and bash. How did you run it? It's intended as a bash script, and indicated as such by the initial #! /bin/bash.

@Michael-T-McCann
Copy link
Contributor

How did you run it?

The same error occurs when I run it with bash make_conda_env.sh or ./make_conda_env.sh. I believe my bash version is 3.2.

@bwohlberg
Copy link
Collaborator Author

The same error occurs when I run it with bash make_conda_env.sh or ./make_conda_env.sh. I believe my bash version is 3.2.

Indeed, not incompatibility between zsh and bash, but use of an incredibly old version of bash (4.0 was released in 2009) that does not support the case fall through syntax using ;;&. I added a test for bash 4 to the script.

Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the script now leads me to update bash. After doing so:

The environment I get fails a bunch of pytests due to scico.random, which in turn (I think) is due to the environment giving me jax version 0.2.27 instead of the pinned version 0.2.26.

Why doesn't the workflow catch these pytest failures on 0.2.27? Because of a bug in the workflow, see #189.

@bwohlberg
Copy link
Collaborator Author

The environment I get fails a bunch of pytests due to scico.random, which in turn (I think) is due to the environment giving me jax version 0.2.27 instead of the pinned version 0.2.26.

Fixed and tested on OSX with Python 3.9.

@bwohlberg bwohlberg merged commit 8537469 into main Jan 26, 2022
@bwohlberg bwohlberg deleted the brendt/conda branch January 26, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Issues related to packaging, dependencies, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants