Fix typing errors and set up mypy workflow action
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwohlberg
added
the
developer
Codecov Report
@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 94.07% 94.15% +0.07%
==========================================
Files 49 49
Lines 3241 3267 +26
==========================================
+ Hits 3049 3076 +27
+ Misses 192 191 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Michael-T-McCann
force-pushed
the
brendt/typing
branch
from
13680fb
to
7cbea48
Compare
FernandoDavis
requested changes
Apr 25, 2022
Michael-T-McCann
approved these changes
Apr 26, 2022
scico/linop/optics.py
Outdated
| @@ -59,13 +59,15 @@ def radial_transverse_frequency( | |||
| raise ValueError("Invalid input dimensions; must be 1 or 2") | |||
|
|
|||
| if np.isscalar(dx): | |||
| dx = (dx,) * ndim | |||
| dx = (dx,) * ndim # type: ignore | |||
There was a problem hiding this comment.
Possibly this could be achieved via a type guarding version of isscalar https://mypy.readthedocs.io/en/latest/type_narrowing.html#user-defined-type-guards
bwohlberg
commented
Apr 27, 2022
FernandoDavis
approved these changes
Apr 28, 2022
|
Remaining issues to be dealt with notes as #284. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typing errors and set up
mypyworkflow actionTo check a single file:
The typing tests are now passing, with some significant limitations, as reflected in the command
Most significantly, this excludes testing of
scico.numpy, which results in 100s of typing errors, primarily due to unrecognized functions (which are dynamically constructed) in that module. Despite these limitations, I propose that we merge this PR now so that future changes are subjected to at least some typing testing. Follow-on projects would be:# type: ignoreto determine whether the error that led to its insertion can instead be resolved by improved type annotation or use of type guards.proxmethod).