Remove problematic array copy operations

[bwohlberg]

The copy calls in the current implementations prevent solving problems using BlockArray variables since copy is not implemented for that class. The copy calls should not be necessary since the relevant working variables should be DeviceArray, and therefore immutable, due to the ensure_on_device calls in initializing them.

[codecov]

Codecov Report

Merging #156 (28eeb7e) into main (ffec40b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files          48       48           
  Lines        3294     3294           
=======================================
  Hits         3035     3035           
  Misses        259      259           

Flag	Coverage Δ
unittests	92.13% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
scico/optimize/_ladmm.py	98.86% <100.00%> (ø)
scico/optimize/_primaldual.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffec40b...28eeb7e. Read the comment docs.

[Michael-T-McCann]

Does this mean these routines are not tested with BlockArrays? Perhaps such tests should be added (as a new issue).

[bwohlberg]

Does this mean these routines are not tested with BlockArrays? Perhaps such tests should be added (as a new issue).

Good point. I will fix this.

[bwohlberg]

Does this mean these routines are not tested with BlockArrays? Perhaps such tests should be added (as a new issue).

Done.