Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common functions in example scripts into new module #151

Merged
merged 23 commits into from
Jan 3, 2022

Conversation

bwohlberg
Copy link
Collaborator

@bwohlberg bwohlberg commented Dec 23, 2021

Move some common functions in example scripts into new scico.examples module.

Also:

  • Fix docstrings in scico.data
  • Trivial docstring edits in examples/scripts/ct_astra_weighted_tv_admm.py
  • For deconv_microscopy_... examples:
    • Changed downsampling rate to 2 (see *)
    • Downsampling rate is no longer required to be even
    • Changed path of cached EPFL BIG data to ~/.cache/scico/examples

(*) Running on GPU may now require setting the XLA environment variables

export XLA_PYTHON_CLIENT_ALLOCATOR=platform
export XLA_PYTHON_CLIENT_PREALLOCATE=false

@bwohlberg bwohlberg added the examples Pertaining to SCICO examples label Dec 23, 2021
@bwohlberg bwohlberg changed the title Move some common functions in example scripts into new scico.example module Move some common functions in example scripts into new module Dec 23, 2021
@bwohlberg bwohlberg changed the title Move some common functions in example scripts into new module Move common functions in example scripts into new module Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #151 (9d95dd6) into main (912bb9e) will increase coverage by 0.00%.
The diff coverage is 92.59%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          47       48    +1     
  Lines        3240     3294   +54     
=======================================
+ Hits         2986     3036   +50     
- Misses        254      258    +4     
Flag Coverage Δ
unittests 92.16% <92.59%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/data/__init__.py 100.00% <ø> (ø)
scico/examples.py 92.59% <92.59%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912bb9e...9d95dd6. Read the comment docs.

@bwohlberg bwohlberg linked an issue Dec 24, 2021 that may be closed by this pull request
3 tasks
@bwohlberg bwohlberg merged commit c32fe22 into main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Pertaining to SCICO examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve deconv_microscopy examples
2 participants