Modify cg_kwargs mechanism in admm.LinearSubproblemSolver #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwohlberg
added
enhancement
tbalke
reviewed
Dec 18, 2021
tbalke
requested changes
Dec 18, 2021
There was a problem hiding this comment.
Good on my side once point of https://github.com/lanl/scico/pull/140/files#r771765711 is resolved.
tbalke
approved these changes
Dec 18, 2021
Codecov Report
@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 47 47
Lines 3206 3209 +3
=======================================
+ Hits 2947 2950 +3
Misses 259 259
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change cg_kwargs mechanism so that default values are preserved unless explicitly changed.
Resolves #69 (but, contrary to the speculation in that issue, some of the examples seem to benefit from controlling both CG tolerance and maximum iterations).