-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to examples scripts #137
Conversation
bwohlberg
commented
Dec 16, 2021
•
edited
Loading
edited
- Improve notebook build script
- don't terminate entire run on single notebook execution failure
- clean up workers after keyboard interrupt
- Minor edits to example script docstrings
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 47 47
Lines 3206 3206
=======================================
Hits 2947 2947
Misses 259 259
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine to me! There's one nitpick but that shouldn't hold back the PR and can be discussed on Monday with the other pending edit.