Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in linop.optics #131

Merged
merged 10 commits into from
Dec 14, 2021
Merged

Fix bugs in linop.optics #131

merged 10 commits into from
Dec 14, 2021

Conversation

bwohlberg
Copy link
Collaborator

  • fix bugs in linop.optics
  • add tests for methods that were broken
  • rename method check_sampling to adequate_sampling

@bwohlberg bwohlberg added the bug Something isn't working label Dec 12, 2021
@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #131 (b0c36c4) into main (0dc831d) will increase coverage by 0.52%.
The diff coverage is 100.00%.

❗ Current head b0c36c4 differs from pull request most recent head 4f1c531. Consider uploading reports for the commit 4f1c531 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   91.34%   91.86%   +0.52%     
==========================================
  Files          47       46       -1     
  Lines        3223     3208      -15     
==========================================
+ Hits         2944     2947       +3     
+ Misses        279      261      -18     
Flag Coverage Δ
unittests 91.86% <100.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/linop/optics.py 95.72% <100.00%> (+14.42%) ⬆️
scico/optimize/admm.py
scico/optimize/_ladmm.py
scico/optimize/pgm.py
scico/optimize/_primaldual.py
scico/optimize/__init__.py
scico/pgm.py 94.81% <0.00%> (ø)
scico/admm.py 95.21% <0.00%> (ø)
scico/primaldual.py 98.68% <0.00%> (ø)
scico/ladmm.py 97.64% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc831d...4f1c531. Read the comment docs.

Copy link
Contributor

@lukepfister lukepfister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bwohlberg bwohlberg merged commit 593e9c2 into main Dec 14, 2021
@bwohlberg bwohlberg deleted the brendt/optics branch December 14, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants