-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move optimizers into optimize package #129
Conversation
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 91.31% 91.34% +0.02%
==========================================
Files 46 47 +1
Lines 3214 3223 +9
==========================================
+ Hits 2935 2944 +9
Misses 279 279
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite the slight awkwardness you mentioned around LinearSubproblemSolver
, this looks like a significant improvement in clarify.
Move optimizers into
optimize
package. Resolves #122.Notes:
solvers
not moved intooptimize
to avoid import loopsadmm
andpgm
submodules are treated differently from_ladmm
and_primaldual
because they include auxiliary classes for which the retention of the submodule prefix is desirable, e.g.admm.LinearSubproblemSolver
ADMM
can be imported from eitherscico.optimize
orscico.optimize.admm
, and similarly for the PGM solver classes