Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New optimization algorithms #117

Merged
merged 22 commits into from
Dec 7, 2021
Merged

New optimization algorithms #117

merged 22 commits into from
Dec 7, 2021

Conversation

bwohlberg
Copy link
Collaborator

Add linearized ADMM and PDHG optimization algorithms.

See also lanl/scico-data#7.

@bwohlberg bwohlberg added the enhancement New feature or request label Nov 30, 2021
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #117 (82a96ea) into main (50e4935) will increase coverage by 0.37%.
The diff coverage is 98.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   90.89%   91.26%   +0.37%     
==========================================
  Files          42       44       +2     
  Lines        2997     3160     +163     
==========================================
+ Hits         2724     2884     +160     
- Misses        273      276       +3     
Flag Coverage Δ
unittests 91.26% <98.15%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/ladmm.py 97.67% <97.67%> (ø)
scico/primaldual.py 98.70% <98.70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e4935...82a96ea. Read the comment docs.

Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"style police" comments are FYI rather than blockers, I can tidy them up later if you wish.

scico/ladmm.py Outdated Show resolved Hide resolved
scico/ladmm.py Outdated Show resolved Hide resolved
scico/primaldual.py Outdated Show resolved Hide resolved
scico/primaldual.py Outdated Show resolved Hide resolved
@bwohlberg bwohlberg merged commit 2f28bfc into main Dec 7, 2021
@bwohlberg bwohlberg deleted the brendt/new-opt-alg branch December 7, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants