Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up notebooks build script #108

Merged
merged 18 commits into from
Nov 23, 2021
Merged

Clean up notebooks build script #108

merged 18 commits into from
Nov 23, 2021

Conversation

bwohlberg
Copy link
Collaborator

Improve Python notebook build script, including removal of the need to exec a bash script. Remove makefile and bash script.

@bwohlberg bwohlberg added the examples Pertaining to SCICO examples label Nov 20, 2021
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.48%. Comparing base (76854da) to head (f7abee9).
Report is 716 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   90.48%   90.48%           
=======================================
  Files          42       42           
  Lines        3028     3028           
=======================================
  Hits         2740     2740           
  Misses        288      288           
Flag Coverage Δ
unittests 90.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to see the makefile go, and I was able to use the new mechanism to build the examples on toro.

@bwohlberg bwohlberg merged commit 4395463 into main Nov 23, 2021
@bwohlberg bwohlberg deleted the brendt/notebooks-build branch November 23, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Pertaining to SCICO examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants