Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling when 3d astra projector called with no GPU available #564

Closed
bwohlberg opened this issue Oct 25, 2024 · 0 comments · Fixed by #567
Closed

Improve error handling when 3d astra projector called with no GPU available #564

bwohlberg opened this issue Oct 25, 2024 · 0 comments · Fixed by #567
Assignees
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies

Comments

@bwohlberg
Copy link
Collaborator

While the 3d astra projector linop.xray.astra.XRayTransform3D requires a GPU, it does not include any tests to confirm that this requirement is satisfied; calling a forward or back projection without a GPU results in the rather opaque "Unknown algorithm type" error from astra. Some error checking should be added: at least in the example scripts that make use of this class, and possibly also in the class itself.

@bwohlberg bwohlberg added the improvement Improvement of existing code, including addressing of omissions or inconsistencies label Oct 25, 2024
@bwohlberg bwohlberg self-assigned this Oct 25, 2024
bwohlberg added a commit that referenced this issue Oct 30, 2024
@bwohlberg bwohlberg mentioned this issue Oct 30, 2024
bwohlberg added a commit that referenced this issue Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant