Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADMM's CircularConvolveSolver not using all the parameters specified #528

Closed
crstngc opened this issue Jun 6, 2024 · 0 comments · Fixed by #532
Closed

ADMM's CircularConvolveSolver not using all the parameters specified #528

crstngc opened this issue Jun 6, 2024 · 0 comments · Fixed by #532
Assignees
@bwohlberg
Labels
bug Something isn't working

Comments

@crstngc
Copy link
Contributor

crstngc commented Jun 6, 2024

The internal initialization of CircularConvolveSolver usesCircularConvolve.from_operator:

https://github.com/lanl/scico/blob/07a41c6652b94a3324b51e146ece22cc0f655649/scico/optimize/_admmaux.py#L414C19-L414C60

ignoring associated parameters (e.g. ndims, center) that may have been included in the configuration of the ADMM solver. This leads to convolutions being applied by default over all the axes even when only a subset of them is intended.
@bwohlberg bwohlberg self-assigned this Jun 7, 2024
@bwohlberg bwohlberg added the bug Something isn't working label Jun 7, 2024
@bwohlberg bwohlberg mentioned this issue Jun 7, 2024
Merged
bwohlberg added a commit that referenced this issue Jun 12, 2024
@bwohlberg
Resolve #528 (#532)
d990555 
* Add correct handling of CircularConvolve ndims attribute

* Add test for CircularConvolve with non-default h_center parameter

* Update copyright year

* Add support for f=None case

* Docstring fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwohlberg bwohlberg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #528 lanl/scico
2 participants
@bwohlberg @crstngc