Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling of FiniteDifference linear operator broken #479

Closed
bwohlberg opened this issue Dec 8, 2023 · 0 comments · Fixed by #480
Closed

Scaling of FiniteDifference linear operator broken #479

bwohlberg opened this issue Dec 8, 2023 · 0 comments · Fixed by #480
Assignees
Labels
bug Something isn't working

Comments

@bwohlberg
Copy link
Collaborator

Scaling of the FiniteDifference linear operator broken; this simple example throws an exception:

from scico.linop import FiniteDifference

A = FiniteDifference(input_shape=(8, 8))
B = 2.0 * A

The problem is due to FiniteDifference being derived from VerticalStack, and the use of self.__class__ in the implementation of __mul__ in VerticalStack.

@bwohlberg bwohlberg added the bug Something isn't working label Dec 8, 2023
@bwohlberg bwohlberg self-assigned this Dec 8, 2023
@bwohlberg bwohlberg mentioned this issue Dec 8, 2023
bwohlberg added a commit that referenced this issue Dec 12, 2023
* Add test for FiniteDifference scaling

* Remove stack-specific operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant