Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warning reported by gcc-9.2.0. #829

Merged
merged 1 commit into from
May 12, 2020

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented May 12, 2020

Background

  • A recent change to SortPermutation.hh to fix LLVM build issues, introduced a gcc build warning.

Purpose of Pull Request

Description of changes

  • Add noexcept to the copy constructor.

Status

@KineticTheory KineticTheory added this to the Draco-7_7_0 milestone May 12, 2020
@KineticTheory KineticTheory self-assigned this May 12, 2020
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #829 into develop will not change coverage.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop    #829   +/-   ##
=======================================
  Coverage     94.2%   94.2%           
=======================================
  Files          367     367           
  Lines        17260   17260           
=======================================
  Hits         16264   16264           
  Misses         996     996           

@KineticTheory KineticTheory merged commit 4e05b67 into lanl:develop May 12, 2020
@KineticTheory KineticTheory deleted the fix-gcc9-build-warn branch May 13, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcc-9.2 complains about SortPermutation.hh
1 participant