Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed shell scripts need +X permissions. #806

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Apr 17, 2020

Background

  • I'm still working out all of the kinks related to switching from BullseyeCoverage to gcov/lcov coverage reporting. I am hopeful this fixes the the last remaining issue. The helper script capture_lcov.sh did not have execute permission when installed.

Purpose of Pull Request

Description of changes

  • When installing shell scripts use install( PROGRAMS ... ) instead of install(FILES ... ).

Status

@KineticTheory KineticTheory added this to the Draco-7_7_0 milestone Apr 17, 2020
@KineticTheory KineticTheory self-assigned this Apr 17, 2020
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #806 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #806   +/-   ##
=======================================
  Coverage     94.0%   94.0%           
=======================================
  Files          367     367           
  Lines        17221   17221           
=======================================
  Hits         16189   16189           
  Misses        1032    1032           

@KineticTheory KineticTheory merged commit b931b48 into lanl:develop Apr 17, 2020
@KineticTheory KineticTheory deleted the fix_permissions_for_installed_scripts branch April 18, 2020 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant