Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SuperLU_DIST from Draco. #790

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Remove SuperLU_DIST from Draco. #790

merged 1 commit into from
Apr 9, 2020

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Apr 3, 2020 •
edited
Loading

Background

  • A Draco client does requires this the SuperLU_DIST Third Party Library, but Draco itself doesn't need to know about it or test it.

Purpose of Pull Request

Description of changes

  • Remove all code and build system support related to SuperLU_DIST.

Status

@KineticTheory
Remove SuperLU_DIST from Draco.
7901705 
+ A Draco client does requires this the SuperLU_DIST Third Party Library, but
  Drao itself doesn't need to know about it or test it.
+ Remove all code and build system support related to SuperLU_DIST.
@KineticTheory KineticTheory added this to the Draco-7_7_0 milestone Apr 3, 2020
@KineticTheory KineticTheory self-assigned this Apr 3, 2020
@KineticTheory
Copy link
Collaborator Author

@david8dixon Do you need this FindSuperLU_DIST.cmake script? FYI - I'm removing it from Draco, so you might need to create it in one of your projects.

@codecov
Copy link

codecov bot commented Apr 3, 2020 •
edited
Loading

Codecov Report

Merging #790 into develop will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #790   +/-   ##
=======================================
  Coverage     94.0%   94.0%           
=======================================
  Files          367     367           
  Lines        17229   17229           
=======================================
  Hits         16197   16197           
  Misses        1032    1032

keadyk
keadyk reviewed Apr 7, 2020
View reviewed changes
Copy link
Collaborator

@keadyk keadyk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KineticTheory This LGTM! Are you still waiting on the go ahead from capsaicin? I can merge when you are ready.

@KineticTheory
Copy link
Collaborator Author

@jhchang-lanl Are you okay with @keadyk merging this PR?

@jhchang-lanl
Copy link
Contributor

@keadyk Go ahead and merge

@keadyk keadyk merged commit f1cd8ac into lanl:develop Apr 9, 2020
@KineticTheory KineticTheory deleted the remove-superludist-dep branch April 9, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keadyk keadyk keadyk left review comments

@jhchang-lanl jhchang-lanl Awaiting requested review from jhchang-lanl

Assignees

@KineticTheory KineticTheory

Labels
dev-env
Projects
None yet
Milestone
Draco-7_7_0
Development

Successfully merging this pull request may close these issues.
3 participants
@KineticTheory @jhchang-lanl @keadyk