Fix for NDI AMW usage

[brryan]

Background

• Passing zaid=2004 to NDI_AtomicMass would cause NDI to return 7 AMWs (for zaid=2004 and other zaids like 20040)
• Tom Saller showed me how to fix this: append a "." to the zaid.

Purpose of Pull Request

• Fix this bug by passing e.g. "2004." instead of "2004"
• Fixes Redmine Issue #1884

Description of changes

• Reformat the ZAID when converting from an integer before passing to NDI.

Status

• Reference:
  • Pre-Merge Code Review
  • CDash Status
• Checks
  • Travis/Appveyor CI checks pass
  • Code coverage does not decrease
  • Valgrind test passes
  • Toss3 checks pass
  • Trinitite checks pass
  • Code reviewed/approved, sufficient DbC checks, testing, documentation

[codecov]

Codecov Report

Merging #771 into develop will increase coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #771   +/-   ##
=======================================
  Coverage     94.0%   94.0%           
=======================================
  Files          367     367           
  Lines        17227   17230    +3     
=======================================
+ Hits         16195   16198    +3     
  Misses        1032    1032           

[keadyk]

LGTM! I'll wait a little longer to see if anything comes in from tt, but I'll merge soon.

@KineticTheory the Cdash coverage build for this PR looks really weird. There's no way this PR could've caused coverage to drop by ~7%, so I'm going to ignore it... it looks like maybe the test directories are getting included for some reason. The codecov report here on GitHub looks fine!

[KineticTheory]

Let's wait for tt. It is backlogged with a cta CI job.

[KineticTheory]

LGTM! I'll wait a little longer to see if anything comes in from tt, but I'll merge soon.

@KineticTheory the Cdash coverage build for this PR looks really weird. There's no way this PR could've caused coverage to drop by ~7%, so I'm going to ignore it... it looks like maybe the test directories are getting included for some reason. The codecov report here on GitHub looks fine!

Yeah. I was looking at that. It seems that @brryan's branch is a bit out-of-date and doesn't have the exclusions for code in test directories and STL headers that I introduced in #751 and updated in #766.

[KineticTheory]

I don't consider the coverage issue to be a blocker. It should merge cleanly.

[KineticTheory]

BTW - the trinitite CI for this PR is next in line and should start within 15 minutes.

[keadyk]

tt passing! Merging now :)