Eliminate 8 build warnings (Visual Studio) #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ There are 8 build warnings in `tstSuperludist` issued by Visual Studio: `warning C4706: assignment within conditional expression` + This commit fixes the build warnings but the test is still failing for unknown reasons. I will defer examining this failure due to its low priority.
Codecov Report
@@ Coverage Diff @@
## develop #572 +/- ##
=======================================
Coverage 93.6% 93.6%
=======================================
Files 377 377
Lines 17608 17608
=======================================
Hits 16498 16498
Misses 1110 1110 |
|
@alexrlongne This is ready, Can you review and merge? |
alexrlongne
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
tstSuperludistissued by Visual Studio:warning C4706: assignment within conditional expressionPurpose of Pull Request
Description of changes
Status