Simplifying and extending analytic opacity models #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Stimulated_Emission_Analytic_Opacity_Model was poorly tested. * Code duplication was a problem in Polynomial_Analytic_Opacity_Model. * There was no capability to model an analytic bound-free opacity (edge). * Removed Stimulated_Emission_Analtyic_Opacity_Model by adding stimulated emission as an option to Polynomial_Analytic_Opacity_Model that is off by default. * Added a bound-free component to Polynomial_Analytic_Opacity_Model that is off by default. The bound-free component has the same energy, temperature, and density scaling as the free-free component. Only the edge location and strength of the edge need to be specified. * Made the constant offset part of the analytic opacity truly constant. It no longer scales with density.
Codecov Report
@@ Coverage Diff @@
## develop #566 +/- ##
=========================================
+ Coverage 93.3% 93.6% +0.3%
=========================================
Files 377 377
Lines 17676 17608 -68
=========================================
+ Hits 16496 16498 +2
+ Misses 1180 1110 -70 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #566 +/- ##
=========================================
+ Coverage 93.3% 93.6% +0.3%
=========================================
Files 377 377
Lines 17676 17608 -68
=========================================
+ Hits 16496 16498 +2
+ Misses 1180 1110 -70 |
KineticTheory
approved these changes
Jan 17, 2019
| const double pows = pow(T / f, c) * pow(nu / h, e) * pow(rho / g, d); | ||
| const double stim = (i <= 0.0) ? 1.0 : 1.0 - exp(-nu / T); | ||
| const double jH = (nu >= k) ? j : 0.0; | ||
| const double opacity = a + pows * stim * (b + jH); |
There was a problem hiding this comment.
Okay for this PR. But you should be cautious about overflow and/or underflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Description of changes
emission as an option to Polynomial_Analytic_Opacity_Model that is off by
default.
by default. The bound-free component has the same energy, temperature, and
density scaling as the free-free component. Only the edge location and strength
of the edge need to be specified.
longer scales with density.
Status