Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Require to Insist to avoid unused variable warning (found in Clang Release build). #563

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Upgrade Require to Insist to avoid unused variable warning (found in Clang Release build). #563

merged 1 commit into from
Jan 17, 2019

Conversation

RyanWollaeger
Copy link
Contributor

@RyanWollaeger RyanWollaeger commented Jan 16, 2019 •
edited by KineticTheory
Loading

Purpose of Pull Request

  • Make 1-line change to remove warning for an unused variable in Release, caught by Clang 6

Description of changes

  • Upgrade assertion from Require to Insist when checking against NUMBER_OF_KNOWN_PRIMES in Halton_Sequence ctor.

Status

KineticTheory
KineticTheory approved these changes Jan 16, 2019
View reviewed changes
Copy link
Collaborator

@KineticTheory KineticTheory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KineticTheory
Copy link
Collaborator

@RyanWollaeger I'll merge this once the CDash report is ready.

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #563 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #563   +/-   ##
=======================================
  Coverage     93.3%   93.3%           
=======================================
  Files          377     377           
  Lines        17676   17676           
=======================================
  Hits         16496   16496           
  Misses        1180    1180

@codecov-io
Copy link

codecov-io commented Jan 16, 2019 •
edited by codecov bot
Loading

Codecov Report

Merging #563 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           develop    #563   +/-   ##
=======================================
  Coverage     93.3%   93.3%           
=======================================
  Files          377     377           
  Lines        17676   17676           
=======================================
  Hits         16496   16496           
  Misses        1180    1180

KineticTheory
KineticTheory requested changes Jan 16, 2019
View reviewed changes
src/rng/Halton_Sequence.cc Outdated Show resolved Hide resolved
@RyanWollaeger RyanWollaeger changed the title Put variable only used in Require in a Remember macro (found in Clang Release build). Upgrade Require to Insist to avoid unused variable warning (found in Clang Release build). Jan 16, 2019
@KineticTheory KineticTheory merged commit b510298 into lanl:develop Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KineticTheory KineticTheory KineticTheory requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanWollaeger @KineticTheory @codecov-io