Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable xthi and ythi unit tests for win32. #558

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Jan 9, 2019

Background

  • Previously, xthi and ythi were updated to allow compilation under Visual Studio. However, the unit tests associated with these binaries were not enabled.

Purpose of Pull Request

  • Enable unit tests c4_tst[XY]thi_[12].

Status

@KineticTheory KineticTheory added this to the Draco-7_1_0 milestone Jan 9, 2019
@KineticTheory KineticTheory self-assigned this Jan 9, 2019
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #558 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #558   +/-   ##
=======================================
  Coverage     93.3%   93.3%           
=======================================
  Files          377     377           
  Lines        17677   17677           
=======================================
  Hits         16497   16497           
  Misses        1180    1180

@KineticTheory
Copy link
Collaborator Author

@clevelam This is ready for your review and merge.

@clevelam
Copy link
Collaborator

LGTM

@clevelam clevelam merged commit eb6ba2c into lanl:develop Jan 15, 2019
@KineticTheory KineticTheory deleted the enable_xythi_tests_win32 branch January 15, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants