Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin supporting nvcc+xl on darwin P9. #1134

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Begin supporting nvcc+xl on darwin P9. #1134

merged 1 commit into from
Sep 14, 2021

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Sep 14, 2021 •
edited by alexrlongne
Loading

Background

  • While nvcc+xl works fine on ATS-2, we have struggled to get this working on Darwin.
  • We were just missing one flag, added here.

Purpose of Pull Request

Status

@KineticTheory KineticTheory added this to the Draco-7_12_0 milestone Sep 14, 2021
@KineticTheory KineticTheory self-assigned this Sep 14, 2021
@KineticTheory
Copy link
Collaborator Author

None of our CI will actually test this change.

@KineticTheory KineticTheory merged commit 3b81b75 into lanl:develop Sep 14, 2021
alexrlongne
alexrlongne reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor

@alexrlongne alexrlongne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for finding this.

@KineticTheory KineticTheory deleted the xlandcuda branch September 16, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrlongne alexrlongne alexrlongne left review comments

Assignees

@KineticTheory KineticTheory

Labels
bug dev-env
Projects
None yet
Milestone
Draco-7_12_0
Development

Successfully merging this pull request may close these issues.
2 participants
@KineticTheory @alexrlongne