Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of threads spawned for tstOMP and tstatomics #1131

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Sep 8, 2021

Background

  • The goal is to improve robustness of these unit tests. On some of our newer test machines we were using more than 100 threads for these tests and this was causing some stability issues.

Purpose of Pull Request

Status

@KineticTheory KineticTheory self-assigned this Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1131 (93a82f0) into develop (751f28b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1131   +/-   ##
=======================================
  Coverage     89.0%   89.0%           
=======================================
  Files          374     374           
  Lines        19258   19258           
=======================================
  Hits         17154   17154           
  Misses        2104    2104           

@KineticTheory
Copy link
Collaborator Author

@alexrlongne I added some set_omp_num_thread calls to limit the number of spawned threads. What do you think about this change?

@alexrlongne
Copy link
Contributor

This is a good change, thanks!

@alexrlongne alexrlongne merged commit 3499862 into lanl:develop Sep 9, 2021
@KineticTheory KineticTheory deleted the tstomp-limit-threads branch September 12, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants