Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region output, with all the cells, to x3d_generator.py. #1112

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

RyanWollaeger
Copy link
Contributor

@RyanWollaeger RyanWollaeger commented Aug 17, 2021

Note: it is planned to eventually permit multiple regions/matids.

Background

  • Some dependent packages may need to parse region files corresponding to the matid field in X3D.
  • Eventually, x3d_generator.py should support multiple simple regions (i.e. matids), but the intent here is to merely ensure compatibility with parsers.

Purpose of Pull Request

  • Add region output, with all the cells, to x3d_generator.py for parsers requiring X3D region files.

Description of changes

  • Add region output, with all the cells, to x3d_generator.py.

Status

Note: it is planned to eventually permit multiple regions/matids.
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #1112 (cb40e3d) into develop (3c93de8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1112   +/-   ##
=======================================
  Coverage     88.9%   88.9%           
=======================================
  Files          376     376           
  Lines        19569   19569           
=======================================
  Hits         17416   17416           
  Misses        2153    2153           

@KineticTheory KineticTheory added this to the Draco-7_12_0 milestone Aug 18, 2021
@KineticTheory KineticTheory merged commit 6240d7e into lanl:develop Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants