Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance opstream by allowing output to a specified ostream. #1106

Merged
merged 4 commits into from
Aug 13, 2021

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Aug 12, 2021

Background

Description of changes

  • Extend the capabilities of opstream by allowing output to be directed to any std::ostream instead of forcing output to std::cout. If the output stream is not specified, it will default to the previous behavior of std::cout.
  • Provide const attribute for some arguments of functions provided in dbc.hh.
  • This PR also serves as a sanity check for the new git pre-commit-copyright hook, Provide git-hook that updates copyright block automagically. #1105.

Status

+ Extend the capabilities of `opstream` by allowing output to be directed to any `std::ostream`
  instead of forcing output to `std::cout`. If the output stream is not specified, it will default
  to the previous behavior of `std::cout`.
+ Provide `const` attribute for some arguments of functions provided in `dbc.hh`.
+ This PR also serves as a sanity check for the new git pre-commit-copyright hook, lanl#1105.
@KineticTheory KineticTheory added this to the Draco-7_12_0 milestone Aug 12, 2021
@KineticTheory KineticTheory self-assigned this Aug 12, 2021
@KineticTheory KineticTheory changed the title Enhance opstream by allowing output to a specified buffer. Enhance opstream by allowing output to a specified ostream. Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #1106 (c9799e0) into develop (f23bf69) will not change coverage.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop   #1106   +/-   ##
=======================================
  Coverage     88.7%   88.7%           
=======================================
  Files          374     374           
  Lines        18593   18593           
=======================================
  Hits         16497   16497           
  Misses        2096    2096           

@keadyk
Copy link
Collaborator

keadyk commented Aug 13, 2021

LGTM!

@keadyk keadyk merged commit 7d85f39 into lanl:develop Aug 13, 2021
@KineticTheory KineticTheory deleted the enhance-opstream branch August 16, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants