-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autopep8 git hook #1100
Merged
Merged
Add autopep8 git hook #1100
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
06e0020
Bad python for commit test
brryan d744b28
?
brryan 18f4d47
Add autopep8
brryan a8381bc
Cleanup
brryan 07b9518
bad formatting
brryan d0df4d9
testing again
brryan dc4e775
One more test
brryan a376c6c
That test didnt work for flake8 anyway
brryan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
#!/usr/bin/env python3 | ||
import os | ||
import subprocess | ||
|
||
if __name__ == '__main__': | ||
output = subprocess.run(['git', 'rev-parse', '--show-toplevel'], capture_output=True) | ||
base_dir = output.stdout.decode('utf-8').strip() | ||
output = subprocess.run(['git', 'status', '--porcelain'], capture_output=True) | ||
all_files = output.stdout.decode('utf-8') | ||
modified_files = [] | ||
for line in all_files.split('\n'): | ||
if 'A' in line[0:2] or 'M' in line[0:2]: | ||
modified_files.append(os.path.join(base_dir, line[2:].strip())) | ||
|
||
for filename in modified_files: | ||
autopep8_call = ['autopep8', '--in-place', filename] | ||
subprocess.call(autopep8_call) | ||
subprocess.call(['git', 'add', filename]) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need
pre-commit-flake8
if we adoptpre-commit-autopep8
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't mind switching to
autopep8
fromflake8
, that would solve the above consistency issue I brought up. I do like thatautopep8
will automatically apply formatting changes, but I don't know if there are reasons for us to still preferflake8
at the CI levelThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The superlinter CI check that we use will run
flake8
. I want to keep that CI because it has a very low maintenance cost. It sounds like we need to keep both for now.