Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random Voronoi mesh to mesh generators #1098

Merged
merged 8 commits into from
Aug 6, 2021

Conversation

brryan
Copy link
Contributor

@brryan brryan commented Aug 5, 2021

Background

  • We want to be able to quickly spin up 2D unstructured meshes that effectively sample different zone connectedness for benchmarking algorithms on unstructured meshes

Purpose of Pull Request

Description of changes

  • Add random Voronoi mesh generator to mesh/python/mesh_types.py
  • Modify mesh/python/x3d_generator.py to support more complex mesh case (e.g. differing numbers of nodes per boundary)

Status

@brryan brryan self-assigned this Aug 5, 2021
Copy link
Contributor

@RyanWollaeger RyanWollaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few minor questions/comments...

src/mesh/python/x3d_generator.py Outdated Show resolved Hide resolved
src/mesh/python/x3d_generator.py Outdated Show resolved Hide resolved
src/mesh/python/x3d_generator.py Outdated Show resolved Hide resolved
src/mesh/python/mesh_types.py Outdated Show resolved Hide resolved
src/mesh/python/mesh_types.py Show resolved Hide resolved
@RyanWollaeger
Copy link
Contributor

What was the issue that precluded differing number of nodes per boundary?

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #1098 (4bc5622) into develop (b366af7) will increase coverage by 2.9%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop   #1098     +/-   ##
=========================================
+ Coverage     85.7%   88.7%   +2.9%     
=========================================
  Files          356     374     +18     
  Lines        17227   18593   +1366     
=========================================
+ Hits         14776   16497   +1721     
+ Misses        2451    2096    -355     

Copy link
Contributor

@RyanWollaeger RyanWollaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanWollaeger RyanWollaeger merged commit 871d8ba into lanl:develop Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants