-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add random Voronoi mesh to mesh generators #1098
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few minor questions/comments...
What was the issue that precluded differing number of nodes per boundary? |
Codecov Report
@@ Coverage Diff @@
## develop #1098 +/- ##
=========================================
+ Coverage 85.7% 88.7% +2.9%
=========================================
Files 356 374 +18
Lines 17227 18593 +1366
=========================================
+ Hits 14776 16497 +1721
+ Misses 2451 2096 -355 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Background
Purpose of Pull Request
Description of changes
mesh/python/mesh_types.py
mesh/python/x3d_generator.py
to support more complex mesh case (e.g. differing numbers of nodes per boundary)Status