Add preliminary framework for generating X3D (and eventually RTT) mesh files. #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add src/mesh/python subdirectory. + Add mesh_type file intended to contain python mesh classes. + Add orth_2d_mesh class to mesh_types: orthogonal quad 2D data. + Add x3d_generator, which creates X3D files from mesh objectes. + Import mesh_types into x3d_generator (for the mesh objects). + Add orth_3d_mesh class stub for eventual 3D mesh file generation. Notes: - An equivalent rtt_generator can be added to take mesh object data to the RTT mesh file format. - Consider using Python 3.7 dataclasses for mesh classes.
|
@brryan Maybe the Voronoi mesh can be introduced as a class with the relevant data in this new python subdirectory, so we can then add an rtt_generator.py (following x3d_generator.py) which can output the format. Let me know if this seems off-base. |
Codecov Report
@@ Coverage Diff @@
## develop #1090 +/- ##
=======================================
Coverage 88.7% 88.7%
=======================================
Files 374 374
Lines 18591 18591
=======================================
Hits 16495 16495
Misses 2096 2096 |
+ Avoid ambiguity of numpy import. + Correct formatting of comments, dictionary, key-value arguments.
RyanWollaeger
force-pushed
the
x3d_gen_framework1
branch
from
d726e86
to
f0eacbc
Compare
KineticTheory
approved these changes
Jul 19, 2021
|
I'm ready to merge this PR. @brryan @kgbudge Do you have any comments for @RyanWollaeger? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Purpose of Pull Request
Description of changes
orth_2d_meshclass to mesh_types: orthogonal quad 2D data.orth_3d_meshclass stub for eventual 3D mesh file generation.Notes:
to the RTT mesh file format.
Status