Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Attempt to replace Travis with GitHub Actions #1070

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Jun 15, 2021

Background

  • Travis is failing because we are using too many resources. Especially bandwidth when pulling docker images.
  • Remove Travis CI and replace it with GitHub Actions CI

Purpose of Pull Request

Description of changes

  • Provide new .github/workflow/*.yml scripts that replicate old code found in .travis.yml.

Status

@KineticTheory KineticTheory changed the title WIP: testing WIP: Attempt to replace Travis with GitHub Actions Jun 15, 2021
@KineticTheory KineticTheory self-assigned this Jun 15, 2021
@KineticTheory KineticTheory added this to the Draco-7_11_0 milestone Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #1070 (384cf12) into develop (2dd63a2) will decrease coverage by 5.3%.
The diff coverage is 30.0%.

❗ Current head 384cf12 differs from pull request most recent head 0587fa8. Consider uploading reports for the commit 0587fa8 to get more accurate results

@@            Coverage Diff            @@
##           develop   #1070     +/-   ##
=========================================
- Coverage     94.0%   88.6%   -5.4%     
=========================================
  Files          368     374      +6     
  Lines        17461   18532   +1071     
=========================================
+ Hits         16423   16432      +9     
- Misses        1038    2100   +1062     

@KineticTheory
Copy link
Collaborator Author

@clevelam There might be hope for switching from Travis to GitHub Actions. This is looking promising.

+ Add workflows for autodoc, gcc+mpi, gcc+scalar, style checker, llvm+mpi, and clang-tidy.
+ Continue using existing Docker containers.
+ Add codecov instructions.
+ Remove travis yaml file.
@clevelam
Copy link
Collaborator

This looks great and I'm going to merge it. Just so I understand. Is this basically just telling the CI to use a pre-existing image that is in your user space on github?

@clevelam clevelam merged commit 00f53cb into lanl:develop Jun 15, 2021
@KineticTheory
Copy link
Collaborator Author

This looks great and I'm going to merge it. Just so I understand. Is this basically just telling the CI to use a pre-existing image that is in your user space on github?

Conceptually, your comment is correct.

  • Start a CI on a Linux system: runs-on: ubuntu-latest
  • Checkout the PR vai git: uses: actions/checkout@v2
  • Download a docker image from dockerhub: uses: docker://kinetictheory/draco-ci-2020nov:spack-gcc
  • Run my custom OS image that we just downloaded, once the OS starts run the shell script travis-run-tests.sh:
docker run ${ci_env} -v ${GITHUB_WORKSPACE}:/home/travis/Draco -e COMPILER=${COMPILER} -e VENDOR_DIR=/vendors -e BUILD_DIR=/home/travis/Draco/build -e SOURCE_DIR=/home/travis/Draco -e STYLE=${STYLE} -e COVERAGE=${COVERAGE} -e WERROR=${WERROR} -e DRACO_C4=${DRACO_C4} -e AUTODOC=${AUTODOC} -e CLANGTIDY=${CLANGTIDY} -e CI=${CI} kinetictheory/draco-ci-2020nov:${DOCKER_TAG} /bin/bash -l -c '/home/travis/Draco/tools/travis-run-tests.sh'

@KineticTheory KineticTheory deleted the demo_gihub_actions branch June 15, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants