rzansel: Tweak SMPI's lrun options for tests that use MPI+OpenMP. #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ While releasing Draco-7_9_0, a couple of tests were spitting out warnings from `lrun`. I worked with LLNL's admins to isolate the issue. For the updated `lrun`, we need to use `--bind=none` instead of `--pack` in our testing system. + I also found a bug related to setting these flags when `OMP_NUM_THREADS` was not set in the developer's environment and provided a fix.
Codecov Report
@@ Coverage Diff @@
## develop #1011 +/- ##
=======================================
Coverage 94.0% 94.0%
=======================================
Files 368 368
Lines 17412 17429 +17
=======================================
+ Hits 16380 16397 +17
Misses 1032 1032 |
alexrlongne
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
lrun. I worked with LLNL's admins to isolate the issue. For the updatedlrun, we need to use--bind=noneinstead of--packin our testing system.OMP_NUM_THREADSwas not set in the developer's environment and provided a fix.Status