Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged #798 Causes build failures #802

Closed
KineticTheory opened this issue Apr 14, 2020 · 0 comments
Closed

Merged #798 Causes build failures #802

KineticTheory opened this issue Apr 14, 2020 · 0 comments
Assignees
@KineticTheory
Labels
bug
Milestone
Draco-7_7_0

Comments

@KineticTheory
Copy link
Collaborator

  • Initital triage indicates that some dll files are not being copied to the binary directory. When tests run, they fail with missing dll errors.
  • Fix a build issue related to Qt dll files. #798 Introduced this issue. It seems that most dll files are installed automatically, but maybe eospac and csk are not.
@KineticTheory KineticTheory added this to the Draco-7_7_0 milestone Apr 14, 2020
@KineticTheory KineticTheory self-assigned this Apr 14, 2020
KineticTheory added a commit to KineticTheory/Draco that referenced this issue Apr 15, 2020
@KineticTheory
For cdi_eospac and compton, teach the build system to prorivde requir…
dc97730 
…ed dlls.

+ After lanl#798, the build system no longer copied the eospac or compton dll to
  the build tree.  When these files are missing at run time, the tests will
  fail.
+ TPLs provided by the vcpkg package manager know how to install themselves
  into the build tree.  This is what allowed the simplifications found in lanl#798
  to work.  However, eospac and compton are not currently provided by vcpkg, so
  they must be copied via `POST_BUILD` rules.
+ This PR fixes issue lanl#802
@KineticTheory KineticTheory mentioned this issue Apr 15, 2020
Merged
6 tasks
KineticTheory added a commit that referenced this issue Apr 15, 2020
@KineticTheory
For cdi_eospac and compton, teach the build system to prorivde requir…
24d6ecc 
…ed dlls. (#803)

+ After #798, the build system no longer copied the eospac or compton dll to
  the build tree.  When these files are missing at run time, the tests will
  fail.
+ TPLs provided by the vcpkg package manager know how to install themselves
  into the build tree.  This is what allowed the simplifications found in #798
  to work.  However, eospac and compton are not currently provided by vcpkg, so
  they must be copied via `POST_BUILD` rules.
+ This PR fixes issue #802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KineticTheory KineticTheory

Labels
bug
Projects
None yet
Milestone
Draco-7_7_0
Development

No branches or pull requests
1 participant
@KineticTheory