FIX: SOC and LinDist3Flow formulations for elements with missing phases #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #428 +/- ##
==========================================
+ Coverage 72.12% 72.50% +0.38%
==========================================
Files 61 61
Lines 15634 15691 +57
==========================================
+ Hits 11276 11377 +101
+ Misses 4358 4314 -44
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pseudocubic
added
Type: Bug
pseudocubic
reviewed
Feb 14, 2023
pseudocubic
reviewed
Feb 14, 2023
pseudocubic
reviewed
Feb 14, 2023
pseudocubic
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug with SOC and LinDist3Flow formulations where diagonal entries of matrix variables were defined with type
Vector{JuMP.VariableRef}(no information about connections) instead ofJuMP.Containers.DenseAxisArray, leading to errors when single- or two-phase elements (nodes, lines, switches) were present in network.Also, this PR adds loads/generator models which are connected between two secondary terminals (240V devices) of center-tapped transformers for SOC formulation.