Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Alternative methods for defining line constants #425

Merged
merged 11 commits into from
Jan 23, 2023

Conversation

pseudocubic
Copy link
Collaborator

  • Added support for computing line constants from WireData, LineGeometry, LineSpacing, TSData and CNData
  • Added Julia library SpecialFunctions for besseli implementation
  • Changed message that line is "being treated as superconducting" from @info to @debug
  • Added support for WireData, LineGeometry, LineSpacing, TSData, and CNData dss objects
  • Fixed bug in dss parser where when properties were assigned via assign_property!, the prop_order was not updated

- Added support for computing line constants from WireData, LineGeometry, LineSpacing, TSData and CNData
- Added Julia library SpecialFunctions for `besselj0` implementation
- Changed message that line is "being treated as superconducting" from `@info` to `@debug`
- Added support for WireData, LineGeometry, LineSpacing, TSData, and CNData dss objects
- Fixed bug in dss parser where when properties were assigned via `assign_property!`, the `prop_order` was not updated
@pseudocubic pseudocubic added the Category: Data Parsers parser issues label Jan 23, 2023
@pseudocubic pseudocubic self-assigned this Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #425 (a2f9aee) into main (aec548a) will increase coverage by 0.37%.
The diff coverage is 83.97%.

@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   71.75%   72.12%   +0.37%     
==========================================
  Files          60       61       +1     
  Lines       15230    15634     +404     
==========================================
+ Hits        10928    11276     +348     
- Misses       4302     4358      +56     
Impacted Files Coverage Δ
src/PowerModelsDistribution.jl 100.00% <ø> (ø)
src/core/constraint_template.jl 75.63% <0.00%> (ø)
src/core/types.jl 100.00% <ø> (ø)
src/io/utils.jl 82.50% <ø> (ø)
src/io/dss/dss_data_structs.jl 75.11% <68.51%> (-5.42%) ⬇️
src/io/dss/line_constants.jl 89.51% <89.51%> (ø)
src/io/dss/dss2eng.jl 92.44% <91.66%> (+0.70%) ⬆️
src/io/dss/dss_parse.jl 90.97% <92.30%> (+0.85%) ⬆️
src/data_model/eng2math.jl 91.40% <100.00%> (+0.06%) ⬆️
src/data_model/units.jl 87.39% <100.00%> (+0.03%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pseudocubic pseudocubic merged commit a4fea73 into main Jan 23, 2023
@pseudocubic pseudocubic deleted the feature/line-geometry branch January 23, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant