-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: Alternative methods for defining line constants #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for computing line constants from WireData, LineGeometry, LineSpacing, TSData and CNData - Added Julia library SpecialFunctions for `besselj0` implementation - Changed message that line is "being treated as superconducting" from `@info` to `@debug` - Added support for WireData, LineGeometry, LineSpacing, TSData, and CNData dss objects - Fixed bug in dss parser where when properties were assigned via `assign_property!`, the `prop_order` was not updated
Codecov Report
@@ Coverage Diff @@
## main #425 +/- ##
==========================================
+ Coverage 71.75% 72.12% +0.37%
==========================================
Files 60 61 +1
Lines 15230 15634 +404
==========================================
+ Hits 10928 11276 +348
- Misses 4302 4358 +56
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
besseli
implementation@info
to@debug
assign_property!
, theprop_order
was not updated