Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: parse_file in .dss files with character UTF-8 0x09 (Tabulation) #395

Merged
merged 5 commits into from
Aug 24, 2022

Conversation

felipemarkson
Copy link
Contributor

@felipemarkson felipemarkson commented Aug 16, 2022

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #395 (b6ca4f7) into main (28995a1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   69.58%   69.60%   +0.01%     
==========================================
  Files          59       59              
  Lines       14607    14607              
==========================================
+ Hits        10165    10167       +2     
+ Misses       4442     4440       -2     
Impacted Files Coverage Δ
src/io/dss/dss_parse.jl 93.10% <100.00%> (ø)
src/io/utils.jl 82.50% <0.00%> (+0.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@felipemarkson
Copy link
Contributor Author

I don't have a MacOs to test why the tests didn't pass :/

@pseudocubic
Copy link
Collaborator

The problem with the unit test should be fixed, could you merge in the latest main branch to trigger the tests to run again?

@pseudocubic pseudocubic merged commit 0f17d69 into lanl-ansi:main Aug 24, 2022
@pseudocubic
Copy link
Collaborator

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tabulation causing error on parse_file
2 participants