Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: count_nodes #183

Merged
merged 2 commits into from
Sep 25, 2019
Merged

ADD: count_nodes #183

merged 2 commits into from
Sep 25, 2019

Conversation

pseudocubic
Copy link
Collaborator

@pseudocubic pseudocubic commented Sep 25, 2019

Adds a function to count the number of nodes in a system, count_nodes.

Also exposes find_bus and find_component functions for export (previous only internal functions), to improve the user experience.

Adds unit tests and updates changelog

Adds a function to count the number of nodes in a system.

Also exposes `find_bus` and `find_component` functions for export (previous only internal functions), to improve the user experience.

Adds unit tests and updates changelog
@pseudocubic pseudocubic added the Type: Enhancement New feature or request label Sep 25, 2019
@pseudocubic pseudocubic added this to the Release v0.6.0 milestone Sep 25, 2019
@pseudocubic pseudocubic self-assigned this Sep 25, 2019
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #183 into master will increase coverage by 0.06%.
The diff coverage is 98.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   89.75%   89.81%   +0.06%     
==========================================
  Files          39       39              
  Lines        3973     4007      +34     
==========================================
+ Hits         3566     3599      +33     
- Misses        407      408       +1
Impacted Files Coverage Δ
src/io/dss_parse.jl 91.41% <100%> (ø) ⬆️
src/io/opendss.jl 96.36% <100%> (ø) ⬆️
src/core/data.jl 93.87% <97.05%> (+7.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18373f7...49ad226. Read the comment docs.

@pseudocubic pseudocubic merged commit e0dca65 into master Sep 25, 2019
@pseudocubic pseudocubic deleted the add/count-nodes branch September 25, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant