REF: Remove loops over conductors from prob #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes any loops over conductors from the problem definitions to avoid confusing users. Loops over conductors, if needed, will happen inside of functions in `src/core/constraint_templates.jl` or `src/core/variables.jl`, particularly for those constraints/variables which merely call back to PowerModels. Adds the following functions: - constraint_mc_storage_loss - constraint_mc_storage_thermal_limit - constraint_mc_thermal_limit_from - constraint_mc_thermal_limit_to - constraint_mc_voltage_magnitude_setpoint - constraint_mv_active_gen_setpoint - variable_mc_generation - variable_mc_generation_on_off Fixes a multinetwork bug in `ref_add_arcs_trans!` Adds an `AbstractWModels` version of `constraint_mc_power_balance` Fixes multinetwork calls in constraint templates and variable constructors (`conductor_ids` should receive `nw` kwarg in multinetwork cases). Multinetwork problem definition made to be internal, similar to how PowerModels does problem definitions in `src/prob/test.jl`, and updated unit test to use new function name. No updates to unit tests were necessary. Changelog updated
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
=========================================
+ Coverage 87.76% 87.87% +0.1%
=========================================
Files 39 39
Lines 3914 3908 -6
=========================================
- Hits 3435 3434 -1
+ Misses 479 474 -5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes any loops over conductors from the problem definitions to avoid confusing users. Loops over conductors, if needed, will happen inside of functions in
src/core/constraint_templates.jlorsrc/core/variables.jl, particularly for those constraints/variables which merely call back to PowerModels.Adds the following functions:
constraint_mc_storage_lossconstraint_mc_storage_thermal_limitconstraint_mc_thermal_limit_fromconstraint_mc_thermal_limit_toconstraint_mc_voltage_magnitude_setpointconstraint_mv_active_gen_setpointvariable_mc_generationvariable_mc_generation_on_offFixes a multinetwork bug in
ref_add_arcs_trans!Adds an
AbstractWModelsversion ofconstraint_mc_power_balanceFixes multinetwork calls in constraint templates and variable constructors (
conductor_idsshould receivenwkwarg in multinetwork cases).Multinetwork problem definition made to be internal, similar to how PowerModels does problem definitions in
src/prob/test.jl, and updated unit test to use new function name.No updates to unit tests were necessary.
Changelog updated