Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Arbitrary sourcebus names #139

Merged
merged 4 commits into from
May 18, 2019
Merged

FIX: Arbitrary sourcebus names #139

merged 4 commits into from
May 18, 2019

Conversation

pseudocubic
Copy link
Collaborator

OpenDSS allows for a sourcebus to not be called sourcebus by using the bus1 kwarg on circuit.

Updates unit tests and changelog

It is possible to specify a sourcebus name with `bus1` on the circuit definition. Adds support for this feature.
@pseudocubic pseudocubic self-assigned this May 17, 2019
@pseudocubic pseudocubic added Type: Bug Something isn't working Category: Data Parsers parser issues labels May 17, 2019
@pseudocubic pseudocubic added this to the Release v0.3.0 milestone May 17, 2019
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #139 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   82.31%   82.33%   +0.01%     
==========================================
  Files          32       32              
  Lines        3105     3107       +2     
==========================================
+ Hits         2556     2558       +2     
  Misses        549      549
Impacted Files Coverage Δ
src/io/opendss.jl 95.75% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952b966...305ac9a. Read the comment docs.

@pseudocubic pseudocubic merged commit c4f93b6 into master May 18, 2019
@pseudocubic pseudocubic deleted the fix/arbitrary-sourcebus branch May 18, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Data Parsers parser issues Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant