Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformer parsing IEEE123 broken #174

Closed
sanderclaeys opened this issue Sep 13, 2019 · 1 comment
Closed

transformer parsing IEEE123 broken #174

sanderclaeys opened this issue Sep 13, 2019 · 1 comment
Assignees
Labels
Category: Data Parsers parser issues Type: Bug Something isn't working

Comments

@sanderclaeys
Copy link
Contributor

IEEE34 now parses correctly, but there still is an issue with the transformer parsing in IEEE123. The transformers have tap setting 1.0 everywhere after parsing. This issue does not appear in IEEE34, so I suspect it is caused by the presence of like somehow.

Take for example the following lines from IEEE123

new transformer.reg4a phases=1          windings=2   bank=reg4     buses=[160.1 160r.1] conns=[wye wye]       kvs=[2.402 2.402] kvas=[2000 2000] XHL=.01 %LoadLoss=0.00001 ppm=0.0
new transformer.reg4b like=reg4a                     bank=reg4     buses=[160.2 160r.2]      ppm=0.0
new transformer.reg4c like=reg4a                     bank=reg4     buses=[160.3 160r.3]      ppm=0.0
Transformer.reg4a.wdg=2 Tap=(0.00625  8 * 1 +)    ! Tap 8
Transformer.reg4b.wdg=2 Tap=(0.00625  1 * 1 +)    ! Tap 1
Transformer.reg4c.wdg=2 Tap=(0.00625  5 * 1 +)    ! Tap 5

My reasoning about the cause goes like this.
The transformers after dss parsing have the property "tap_2". However, in create_transformer, the kwarg :wdg_2=>"2" is missing and therefore the second tap is never applied.

pseudocubic added a commit that referenced this issue Sep 13, 2019
This fixes several issues with the parsing of transformers:

1. transformers with `windings=3` were not getting their data types parsed correctly via `parse_dss_with_dtypes!` because by default `windings=2`. Corrected this by changing `windings=3` for when no name is given (how dtype parsing works)

2. transformers where `wdg` was not specified in the initial definition, but is updated later, e.g. `transformer.name.wdg=3 tap=0.9`, was not properly updating the tap property on `wdg=3` because `wdg_3=3` was not added to the parsed structure. Corrected this by ensuring `wdg_3=3` was added.

Updated unit tests.

Closes #174
@pseudocubic pseudocubic self-assigned this Sep 13, 2019
@pseudocubic pseudocubic added Type: Bug Something isn't working Category: Data Parsers parser issues labels Sep 13, 2019
@pseudocubic pseudocubic added this to the Release v0.6.0 milestone Sep 13, 2019
@pseudocubic
Copy link
Collaborator

Fix in v0.6-rc branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Data Parsers parser issues Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants