Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linecode frequency #159

Closed
sanderclaeys opened this issue Aug 21, 2019 · 0 comments
Closed

linecode frequency #159

sanderclaeys opened this issue Aug 21, 2019 · 0 comments
Assignees
@pseudocubic
Labels
Category: Data Parsers parser issues Type: Bug Something isn't working
Milestone
Release v0.6.0

Comments

@sanderclaeys
Copy link
Contributor

Linecodes can be specified at a certain frequency, other than the system frequency. This then is rescaled by a certain factor.

Options

  • implement this behaviour
  • throw an error when this property is specified at the linecode level

This can be hard to debug, because 'DefaultBaseFrequency' is state-full, and can be affected by previous runs.
pseudocubic added a commit that referenced this issue Aug 29, 2019
@pseudocubic
FIX: Wrong setting of basefreq on lines / linecodes (OpenDSS)
fbeab55 
When lines / linecodes do not have the basefreq property, internally the basefreq was previous set to 60 Hz, even if the circuit basefreq is e.g. 50 Hz.

This fix changes this behavior so that if basefreq is not given on a line or linecode, the basefreq for that line is the circuit level basefreq.

The default basefreq for the circuit is still 60 Hz if `set defaultbasefreq` is not used; a warning is given if this command is missing.

Updates unit tests and changelog

Closes #159
@pseudocubic pseudocubic mentioned this issue Aug 29, 2019
Merged
pseudocubic added a commit that referenced this issue Aug 29, 2019
@pseudocubic
FIX: Wrong setting of basefreq on lines / linecodes (OpenDSS)
1aa41e4 
When lines / linecodes do not have the basefreq property, internally the basefreq was previous set to 60 Hz, even if the circuit basefreq is e.g. 50 Hz.

This fix changes this behavior so that if basefreq is not given on a line or linecode, the basefreq for that line is the circuit level basefreq.

The default basefreq for the circuit is still 60 Hz if `set defaultbasefreq` is not used; a warning is given if this command is missing.

Updates unit tests and changelog

Closes #159
pseudocubic added a commit that referenced this issue Aug 29, 2019
@pseudocubic
FIX: Wrong setting of basefreq on lines / linecodes (OpenDSS) (#163)
a647fbd 
When lines / linecodes do not have the basefreq property, internally the basefreq was previous set to 60 Hz, even if the circuit basefreq is e.g. 50 Hz.

This fix changes this behavior so that if basefreq is not given on a line or linecode, the basefreq for that line is the circuit level basefreq.

The default basefreq for the circuit is still 60 Hz if `set defaultbasefreq` is not used; a warning is given if this command is missing.

Updates unit tests and changelog

Closes #159
@pseudocubic pseudocubic added this to the Release v0.6.0 milestone Sep 4, 2019
@pseudocubic pseudocubic added Type: Bug Something isn't working Category: Data Parsers parser issues labels Sep 4, 2019
@pseudocubic pseudocubic self-assigned this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pseudocubic pseudocubic

Labels
Category: Data Parsers parser issues Type: Bug Something isn't working
Projects
None yet
Milestone
Release v0.6.0
Development

No branches or pull requests
2 participants
@pseudocubic @sanderclaeys