FIX: bug in add_setpoint functions for MLD

add_setpoint_demand, add_setpoint_shunt needed to be converted to conductorless properly.

Adds unit test to ensure this remains fixed.

Updates README.md to indicate ACP works with MLD

Updates CHANGELOG.md in preparation for release v0.5.1

CHANGELOG.md

@@ -2,6 +2,9 @@ PowerModelsDistribution.jl Change Log
 ===================================
 
 ### staged
+- none
+
+### v0.5.1
 - Add continuous load shedding problem (mld)
 
 ### v0.5.0
@@ -24,7 +27,6 @@ PowerModelsDistribution.jl Change Log
 - Fix bug in OpenDSS parse of Capacitors [zbase factor and wrong sign] (#138)
 - Add voltage balance constraints (#129)
 
-
 ### v0.3.0
 - Update to JuMP v0.19/MathOptInterface
 

README.md

@@ -8,15 +8,14 @@ Dev:
 [![codecov](https://codecov.io/gh/lanl-ansi/PowerModelsDistribution.jl/branch/master/graph/badge.svg)](https://codecov.io/gh/lanl-ansi/PowerModelsDistribution.jl)
 [![docs](https://img.shields.io/badge/docs-latest-blue.svg)](https://lanl-ansi.github.io/PowerModelsDistribution.jl/latest/)
 
-
 PowerModelsDistribution.jl is an extention package of PowerModels.jl for Steady-State Power Distribution Network Optimization.  It is designed to enable computational evaluation of emerging power network formulations and algorithms in a common platform.  The code is engineered to decouple problem specifications (e.g. Power Flow, Optimal Power Flow, ...) from the power network formulations (e.g. AC, linear-approximation, SOC-relaxation, ...).
 This enables the definition of a wide variety of power network formulations and their comparison on common problem specifications.
 
 **Core Problem Specifications**
 
 * Power Flow (pf)
 * Optimal Power Flow (opf), for the Bus Injection Model (BIM) as well as the Branch Flow Model (BFM)
-* Continuous load shed, minimum load delta (mld), for the Branch Flow Model (LPLinUBFPowerModel) and Network Flow Approximation (NFAPowerModel)
+* Continuous load shed, minimum load delta (mld), for the Branch Flow Model (LPLinUBFPowerModel), AC Polar (ACPPowerModel), and Network Flow Approximation (NFAPowerModel)
 
 **Core Network Formulations**
 
@@ -36,7 +35,6 @@ This enables the definition of a wide variety of power network formulations and
 
 Community-driven development and enhancement of PowerModelsDistribution are welcome and encouraged. Please fork this repository and share your contributions to the master with pull requests.
 
-
 ## Acknowledgments
 
 This code has been developed as part of the Advanced Network Science Initiative at Los Alamos National Laboratory.  The primary developers are David Fobes(@pseudocubic) and Carleton Coffrin(@ccoffrin) with support from the following contributors:

src/core/solution.jl

@@ -399,16 +399,16 @@ end
 
 "add load setpoints for load shed problem"
 function add_setpoint_load!(sol, pm::_PMs.GenericPowerModel{T}) where T
-    _PMs.add_setpoint!(sol, pm, "load", "pd", :z_demand; scale = (x,item,cnd) -> x*item["pd"][cnd])
-    _PMs.add_setpoint!(sol, pm, "load", "qd", :z_demand; scale = (x,item,cnd) -> x*item["qd"][cnd])
+    _PMs.add_setpoint!(sol, pm, "load", "pd", :z_demand; scale = (x,item,cnd) -> x*item["pd"], conductorless=true)
+    _PMs.add_setpoint!(sol, pm, "load", "qd", :z_demand; scale = (x,item,cnd) -> x*item["qd"], conductorless=true)
     _PMs.add_setpoint!(sol, pm, "load", "status", :z_demand; default_value = (item) -> if (item["status"] == 0) 0.0 else 1.0 end, conductorless=true)
 end
 
 
 "add shunt setpoints for load shed problem"
 function add_setpoint_shunt!(sol, pm::_PMs.GenericPowerModel{T}) where T
-    _PMs.add_setpoint!(sol, pm, "shunt", "gs", :z_shunt; scale = (x,item,cnd) -> x*item["gs"][cnd])
-    _PMs.add_setpoint!(sol, pm, "shunt", "bs", :z_shunt; scale = (x,item,cnd) -> x*item["bs"][cnd])
+    _PMs.add_setpoint!(sol, pm, "shunt", "gs", :z_shunt; scale = (x,item,cnd) -> x.*item["gs"], conductorless=true)
+    _PMs.add_setpoint!(sol, pm, "shunt", "bs", :z_shunt; scale = (x,item,cnd) -> x.*item["bs"], conductorless=true)
     _PMs.add_setpoint!(sol, pm, "shunt", "status", :z_shunt; default_value = (item) -> if (item["status"] == 0) 0.0 else 1.0 end, conductorless=true)
 end
 

test/tp_mld.jl

@@ -6,6 +6,8 @@
 
             @test result["termination_status"] == PMs.LOCALLY_SOLVED
             @test isapprox(result["objective"], 0.3295; atol = 1e-4)
+            @test all(isapprox(result["solution"]["load"]["1"]["pd"], [3.0, 3.0, 3.0]; atol=1e-4))
+            @test all(isapprox(result["solution"]["load"]["1"]["qd"], [0.9861, 0.9861, 0.9861]; atol=1e-4))
 
             @test isapprox(result["solution"]["load"]["1"]["status"], 1.000; atol = 1e-3)
         end