Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tool var type error #9937

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: tool var type error #9937

merged 1 commit into from
Oct 28, 2024

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Oct 28, 2024

Description

Fix tool var type error. When it is number or select, it should be variable instead of constant.

Related: #9861

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 28, 2024
@iamjoel iamjoel requested a review from JzoNgKVO October 28, 2024 07:33
@dosubot dosubot bot added the 🐞 bug Something isn't working label Oct 28, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 28, 2024
@iamjoel iamjoel merged commit 705946c into main Oct 28, 2024
7 checks passed
@iamjoel iamjoel deleted the fix/tool-default-tool-var-type branch October 28, 2024 07:36
@laipz8200 laipz8200 mentioned this pull request Oct 28, 2024
Merged
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@iamjoel @JunXu01
fix: tool var type error (langgenius#9937)
bf3ea67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JzoNgKVO JzoNgKVO JzoNgKVO approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamjoel @JzoNgKVO