Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking the last piece of data on each page is a duplicate issue, which can be solved by adding the id field to the order by rig and using a unique field #9799

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

yuanboao
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This problem is in the intelligent assistant Q&A function, in which the annotation option of the last piece of data on each page is duplicated, the problem here is because the value of the create_at field in the database table is the same for all records, and in the case of a large number of duplicate create_at values, the database may have errors in determining the boundaries of pagination. When the database performs a pagination query, it needs to determine which records belong to the current page, and the internal logic of the database in handling pagination is messed up with a large number of duplicate create_at values. Because it can't distinguish records based on create_at field. This can cause the database to incorrectly include the same record multiple times in the result set in some cases, especially near page boundaries. This can result in the last record on each page being duplicated.
Therefore, to solve this problem, you can use a field that can uniquely identify each record after the create_at as the main basis for sorting. When the value of the create_at id is the same, the id field will be pagination according to the value of the id field, so that the pagination can be controlled more accurately.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Oct 24, 2024
…ue field ID to the end of order by

Signed-off-by: root <[email protected]>
@crazywoola
Copy link
Member

Please fix the lint errors.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 25, 2024
@crazywoola crazywoola merged commit 4693080 into langgenius:main Oct 25, 2024
6 checks passed
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
…ch can be solved by adding the id field to the order by rig and using a unique field (langgenius#9799)

Signed-off-by: root <[email protected]>
Co-authored-by: root <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants