Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(file_factory): improve filename and mime type determination #9784

Merged

Conversation

laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Oct 24, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

Description

  • Simplify filename extraction by always using content disposition if available.
  • Default to URL parsing when filename isn't provided in response headers.
  • Ensure consistent fallback of 'unknown_file' when filename is missing.
  • Clarify mime type handling by using predefined or guessed types more effectively.
  • Streamline file size and mime type extraction to handle empty or missing headers gracefully.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

- Simplify filename extraction by always using content disposition if available.
- Default to URL parsing when filename isn't provided in response headers.
- Ensure consistent fallback of 'unknown_file' when filename is missing.
- Clarify mime type handling by using predefined or guessed types more effectively.
- Streamline file size and mime type extraction to handle empty or missing headers gracefully.
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Oct 24, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 24, 2024
@laipz8200 laipz8200 merged commit e54b7cd into main Oct 24, 2024
9 checks passed
@laipz8200 laipz8200 deleted the refactor/improve-filename-and-mime-type-determination branch October 24, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants