Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workflow [if node] checklist #9699

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

zxhlyh
Copy link
Collaborator

@zxhlyh zxhlyh commented Oct 23, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@zxhlyh zxhlyh requested a review from iamjoel October 23, 2024 06:52
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Oct 23, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 23, 2024
@zxhlyh zxhlyh merged commit c3473b5 into main Oct 23, 2024
7 checks passed
@zxhlyh zxhlyh deleted the fix/workflow-if-node-checklist branch October 23, 2024 07:46
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Oct 24, 2024
* commit '400392230b47fff5d011b55afd8b0f8b8083ade0': (74 commits)
  fixed: variable reference error (langgenius#9722)
  add vdb py test (langgenius#9706)
  downgrade unstructured nltk version (langgenius#9726)
  remove ppt import (langgenius#9721)
  Modify characters (langgenius#9707)
  chore: update version to 0.10.1 (langgenius#9689)
  fix: refresh current page if url contains token (langgenius#9718)
  Revert "Feat: use file size limit from api" (langgenius#9714)
  feat: support user-defined configuration of log file size and retention count (langgenius#9610)
  build(deps): bump next from 14.2.4 to 14.2.10 in /web (langgenius#9713)
  Feat: use file size limit from api (langgenius#9711)
  feat(model_runtime): add new model 'claude-3-5-sonnet-20241022' (langgenius#9708)
  build(deps): bump mermaid from 10.4.0 to 10.9.3 in /web (langgenius#9709)
  nltk security issue and upgrade unstructured (langgenius#9558)
  feat: added claude 3.5 sonnet v2 model to Google Cloud Vertex AI (langgenius#9688)
  fix: revert ref usage in handleFormChange to fix IME input issues (langgenius#9672)
  Help documentation URL correction (langgenius#9704)
  fix: workflow [if node] checklist (langgenius#9699)
  feat(api): add video and audio file size limits to upload config (langgenius#9703)
  fix: remove email code login redirect (langgenius#9698)
  ...

# Conflicts:
#	web/yarn.lock
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants