-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(variables): replace deprecated 'get_any' with 'get' method #9584
refactor(variables): replace deprecated 'get_any' with 'get' method #9584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Long-awaited refactoring.
- Removed deprecated `get_any` method in favor of the `get` method for variable retrieval across multiple nodes. - Improved error handling for variable retrieval by adding checks for variable existence and type validation. - Introduced specific error messages for missing or invalid variable types to enhance debugging capabilities.
0a0d24f
to
eeecdb0
Compare
This refactoring is breaking many workflows because some users were reliant on the previous behavior where input variables could be null. The deprecated get_any method allowed workflows to proceed even with missing or null values, providing fault tolerance. The new get method is stricter and requires all variables to exist, resulting in unexpected failures for workflows that aren't explicitly handling missing inputs. |
You are right. We allow the Optional variable in the START Node to be empty, but we don’t permit misreferenced variables in other cases. This refactoring is necessary to provide a more manageable and optimized user experience in the future. |
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
get_any
method in favor of theget
method for variable retrieval across multiple nodes.Fixes
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration