Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): improve database session handling and variable management #9581

Merged

Conversation

laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Oct 21, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • Implement context manager for database session in WorkflowCycleManage for better resource management.
  • Remove unnecessary None check for values in VariablePool.
  • Modify variable retrieval in LLMNode to ensure consistent object handling.

Fixes #9574

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

- Implement context manager for database session in WorkflowCycleManage for better resource management.
- Remove unnecessary None check for values in VariablePool.
- Modify variable retrieval in LLMNode to ensure consistent object handling.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 21, 2024
@YIXIAO0 YIXIAO0 self-requested a review October 21, 2024 16:37
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 21, 2024
@YIXIAO0 YIXIAO0 removed their request for review October 21, 2024 16:37
@laipz8200 laipz8200 merged commit c063617 into main Oct 21, 2024
9 checks passed
@laipz8200 laipz8200 deleted the fix/improve-database-session-handling-and-variable-management branch October 21, 2024 16:42
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API and Preview can't work after new release
2 participants