Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing vikingdb param in docker .env.example #9334

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: add missing vikingdb param in docker .env.example #9334

merged 1 commit into from
Oct 15, 2024

Conversation

yaoice
Copy link
Contributor

@yaoice yaoice commented Oct 14, 2024 •
edited
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Add missing vikingdb param in docker .env.example

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 📚 documentation Improvements or additions to documentation labels Oct 14, 2024
crazywoola
crazywoola previously approved these changes Oct 14, 2024
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 14, 2024
@crazywoola
Copy link
Member

Still something wrong with the lint.

@yaoice yaoice force-pushed the fix/add-missing-parameter branch 5 times, most recently from 43dc885 to 345effc Compare October 15, 2024 02:27
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 15, 2024
@yaoice yaoice force-pushed the fix/add-missing-parameter branch 2 times, most recently from 867eeb4 to 41cea43 Compare October 15, 2024 02:48
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 15, 2024
@yaoice yaoice marked this pull request as draft October 15, 2024 03:01
@yaoice yaoice force-pushed the fix/add-missing-parameter branch 2 times, most recently from c3591c2 to 92fb90d Compare October 15, 2024 03:04
@yaoice
Copy link
Contributor Author

yaoice commented Oct 15, 2024

Still something wrong with the lint.

@crazywoola Has our CI upgraded any configurations? I did a test. I only made the following change. As a result, the style check also cannot pass.
image

@yaoice yaoice force-pushed the fix/add-missing-parameter branch 2 times, most recently from 0a2eb8c to cff4c34 Compare October 15, 2024 09:07
@yaoice
Copy link
Contributor Author

yaoice commented Oct 15, 2024

It seems to be a problem with actions-poetry itself. The issue reference: abatilo/actions-poetry#76

@crazywoola
Copy link
Member

Can you try to checkout from main and pick these commit.

@bowenliang123 bowenliang123 mentioned this pull request Oct 15, 2024
Merged
12 tasks
@crazywoola crazywoola marked this pull request as ready for review October 15, 2024 11:11
@crazywoola crazywoola merged commit bc0dad6 into langgenius:main Oct 15, 2024
6 checks passed
@dosubot dosubot bot added the 🐞 bug Something isn't working label Oct 15, 2024
@yaoice yaoice deleted the fix/add-missing-parameter branch October 15, 2024 11:38
@yaoice
Copy link
Contributor Author

yaoice commented Oct 15, 2024

Can you try to checkout from main and pick these commit.

Sorry I only saw it now. Thanks a lot.

ZhouhaoJiang added a commit that referenced this pull request Oct 17, 2024
@ZhouhaoJiang
Merge branch 'main' into feat/new-login
abe6a1b 
* main: (35 commits)
  fix #9409 (#9433)
  update dataset clean rule (#9426)
  add clean 7 days datasets (#9424)
  fix: resolve overlap issue with API Extension selector and modal (#9407)
  refactor: update the default values of top-k parameter in vdb to be consistent (#9367)
  fix: incorrect webapp image displayed (#9401)
  Fix/economical knowledge retrieval (#9396)
  feat: add timezone conversion for time tool (#9393)
  fix: Deprecated gemma2-9b model in Fireworks AI Provider (#9373)
  feat: storybook (#9324)
  fix: use gpt-4o-mini for validating credentials (#9387)
  feat: Enable baiduvector intergration test (#9369)
  fix: remove the stream option of zhipu and gemini (#9319)
  fix: add missing vikingdb param in docker .env.example (#9334)
  feat: add minimax abab6.5t support (#9365)
  fix: (#9336 followup) skip poetry preperation in style workflow when no change in api folder (#9362)
  feat: add glm-4-flashx, deprecated chatglm_turbo (#9357)
  fix: Azure OpenAI o1 max_completion_token and get_num_token_from_messages error (#9326)
  fix: In the output, the order of 'ta' is sometimes reversed as 'at'. #8015 (#8791)
  refactor: Add an enumeration type and use the factory pattern to obtain the corresponding class (#9356)
  ...
ZhouhaoJiang added a commit that referenced this pull request Oct 17, 2024
@ZhouhaoJiang
Merge branch 'feat/new-login' into test/new-login-testing
e09953a 
* feat/new-login: (30 commits)
  feat: add init login type
  fix #9409 (#9433)
  update dataset clean rule (#9426)
  add clean 7 days datasets (#9424)
  fix: resolve overlap issue with API Extension selector and modal (#9407)
  refactor: update the default values of top-k parameter in vdb to be consistent (#9367)
  fix: incorrect webapp image displayed (#9401)
  Fix/economical knowledge retrieval (#9396)
  feat: add timezone conversion for time tool (#9393)
  fix: Deprecated gemma2-9b model in Fireworks AI Provider (#9373)
  feat: storybook (#9324)
  fix: use gpt-4o-mini for validating credentials (#9387)
  feat: Enable baiduvector intergration test (#9369)
  fix: remove the stream option of zhipu and gemini (#9319)
  fix: add missing vikingdb param in docker .env.example (#9334)
  feat: add minimax abab6.5t support (#9365)
  fix: (#9336 followup) skip poetry preperation in style workflow when no change in api folder (#9362)
  feat: add glm-4-flashx, deprecated chatglm_turbo (#9357)
  fix: Azure OpenAI o1 max_completion_token and get_num_token_from_messages error (#9326)
  fix: In the output, the order of 'ta' is sometimes reversed as 'at'. #8015 (#8791)
  ...
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
@yaoice @lau-td
fix: add missing vikingdb param in docker .env.example (langgenius#9334)
94a213d
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@yaoice @JunXu01
fix: add missing vikingdb param in docker .env.example (langgenius#9334)
b76b948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola left review comments

Assignees
No one assigned
Labels
🐞 bug Something isn't working 📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaoice @crazywoola