Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the margin for the rerank switch in retrieval setting #9124

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

YIXIAO0
Copy link
Contributor

@YIXIAO0 YIXIAO0 commented Oct 9, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@YIXIAO0 YIXIAO0 requested a review from zxhlyh October 9, 2024 10:06
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 9, 2024
@YIXIAO0 YIXIAO0 requested review from iamjoel and removed request for zxhlyh October 9, 2024 10:09
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 9, 2024
@YIXIAO0 YIXIAO0 merged commit cbd3ffe into main Oct 9, 2024
7 checks passed
@YIXIAO0 YIXIAO0 deleted the fix/margin-in-rerank-switch branch October 9, 2024 10:26
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants